Implement single-project "super-build" #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassava
added
the
breaking change
New:
- Add `cloe-meta` package to replace previous role of `cloe`.
- Add `cloe-plugins-core` package recipe (but do not build by default).
- Add editable builds to GitHub workflow `build-cloe` matrix.
Changed:
- Package `cloe` provides all Cloe packages compiled in one go.
This is a boon to development, as we make `cloe` editable and
only have to work with a single package.
It also massively speeds up compilation:
- Conan and CMake configuration is only performed once.
- All cores can now be utilized much more effectively during the build
process.
- Do not aggressively lint everything
The developer can do this themselves by setting a cmake define:
https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_CLANG_TIDY.html
- Renamed top-level Make targets:
- `status` is now `status-all`
- `export` is now `export-all`
- `deploy` is now `deploy-all`
- `clean` is now `clean-all`
- `purge` is now `purge-all`
- The following top-level Make targets just refer to `cloe` super-build package:
- `package`
- `smoketest`
- `smoketest-deps`
- `status`
- `export`
Fixed:
- Plugin Conan configurations do not export correct library path.
We still support multiple profiles, but this makes it easier to support the cloe super-build and should also make it easier to develop and maintain tests.
|
Note: If you try to use I'm not sure how it is if |
I added such a test-case and documented the results. |
vho8fe
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloe packages are distributed individually, and nominally have been developed individually, despite always being released with a unified version. Unfortunately, Conan does not provide good tooling for developing in a workspace of federated packages, and the workflows that we've had to use have made development iteration complicated, longer, and more tiring than they need to be.
This PR converts the
cloepackage from a meta-package to a super-build containing all other packages.A new package,
cloe-meta, takes the role that the previouscloepackage took.Questions:
cloeand another package thatcloeprovides? This was fine in the past, but I think it will not work anymore.cloe-meta? Because of Conan v1 limitations, it's not even useful as a lockfile recipe, which is what I intended to use it for.